fix(tui v2): normalize first printable-key insert path in InputArea#587
Open
rodboev wants to merge 1 commit into
Open
fix(tui v2): normalize first printable-key insert path in InputArea#587rodboev wants to merge 1 commit into
rodboev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontends/tuiapp_v2.pywithout touching other files.InputArea._on_key()goes through the same insertion path used by paste/newline via_insert_via_keyboard(), including a Windows-safe fallback.Root cause
InputArea._on_key(), printable keys relied onsuper()._on_key(event).event.is_printablecan be true whileevent.characteris missing, which can cause the baseTextAreainsertion path to not apply that first key reliably.Fix
frontends/tuiapp_v2.py:2334insideInputArea._on_key():super()path.event.characterfirst and falls back toevent.keywhencharacterisNoneandkeyis a single character._insert_via_keyboard()._history_indeximmediately for in-line editing (same intent as existing history-reset behavior).Verification
python -m py_compile frontends/tuiapp_v2.pypython -c "import ast; ast.parse(open('frontends/tuiapp_v2.py', encoding='utf-8').read())"python frontends/tuiapp_v2.py— run attempt blocked by existing runtime config issue in this environment:ZeroDivisionError: integer modulo by zeroinagentmain.py:84(load_llm_sessions()with empty LLM config list).